Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve resource exhausted error message #584

Merged
merged 4 commits into from
Oct 31, 2024
Merged

chore: improve resource exhausted error message #584

merged 4 commits into from
Oct 31, 2024

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Oct 31, 2024 •
edited
Loading

Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1039

Passes the RpcException to the LimitExceededError so it can parse the trailer metadata or error details to determine the most specific error message wrapper to return.

@anitarua anitarua marked this pull request as ready for review October 31, 2024 18:41
@anitarua anitarua requested a review from a team October 31, 2024 18:55
@anitarua anitarua requested a review from malandis October 31, 2024 20:26
malandis
malandis approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@anitarua anitarua merged commit 4a8b746 into main Oct 31, 2024
8 checks passed
@anitarua anitarua deleted the resource-exhausted branch October 31, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malandis malandis malandis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitarua @malandis